Skip to content

features-linux: expose IntelRdt monitoring support #1290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

marquiz
Copy link
Contributor

@marquiz marquiz commented Aug 4, 2025

Commit 34a39b9 introduced the "linux.intelRdt.enableMonitoring" field. This patch supplements it by adding "linux.intelRdt.monitoring" field in the features.json to check if the runtime implementation supports the new field of the spec.

Refs: #1287

@marquiz
Copy link
Contributor Author

marquiz commented Aug 4, 2025

Or could/should we just rely on ociVersionMax?

@marquiz marquiz force-pushed the devel/rdt-features-monitoring branch from 85d1729 to 5786013 Compare August 4, 2025 07:35
Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marquiz
Copy link
Contributor Author

marquiz commented Aug 15, 2025

ping @AkihiroSuda @utam0k

Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs rebase

@AkihiroSuda AkihiroSuda added this to the v1.3.0 milestone Aug 17, 2025
Commit 34a39b9 introduced the
"linux.intelRdt.enableMonitoring" field. This patch supplements it by
adding "linux.intelRdt.monitoring" field in the features.json to check
if the runtime implementation supports the new field of the spec.

Signed-off-by: Markus Lehtonen <[email protected]>
@marquiz marquiz force-pushed the devel/rdt-features-monitoring branch from 5786013 to 0758679 Compare August 18, 2025 06:55
@marquiz
Copy link
Contributor Author

marquiz commented Aug 18, 2025

Needs rebase

Thx for the note. Rebased

@AkihiroSuda AkihiroSuda merged commit 383cadb into opencontainers:main Aug 18, 2025
4 checks passed
@marquiz marquiz deleted the devel/rdt-features-monitoring branch August 18, 2025 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants